Properly sanitizing column names for MySQL
There are times when you need to send SQL to the database, like this:
Copydef self.some_count(field) field = connection.quote_column_name(field) scoped(:select => "COUNT(DISTINCT #{field}) AS count") end
Although the given variable is sanitized here, the MySQLAdapter's (and probably other adapters as well) method for this is insufficient as it only wraps backticks around it, not helping against injection:
CopyKlass.some_count("id`); DELETE FROM users; -- ") # Will result in this SQL which is valid but definitely undesirable: SELECT COUNT(DISTINCT `id`); DELETE FROM users; -- `) AS count;
If you are doing something like the above, the correct way is to first remove all backticks from the given string. Afterwards the unsafe code is wrapped in backticks. The resulting SQL query will look like this:
CopySELECT COUNT(DISTINCT `id); DELETE FROM users; -- `) AS count;
MySQL will complain about a missing column 'id); DELETE FROM users; -- ' which is safe.
Put the attached fix for the MySQL adapter into config/initializers/.
By refactoring problematic code and creating automated tests, makandra can vastly improve the maintainability of your Rails application.
