MySQL: Do not use "WHERE id IN (SELECT ....)"

Note: This applies specifically to MySQL. In PostgreSQL for example, this is not an issue.

If you care about performance, never use a query like

CopyUPDATE users SET has_message = 1 WHERE users.id IN (SELECT user_id FROM messages)

MySQL does not optimize this and seems to scan the temporary table, which isn't indexed, for every row in the update statement. This applies to other statements than UPDATE as well.

Instead, either use a JOIN like

CopyUPDATE users INNER JOIN messages ON messages.user_id = users.id SET has_message = 1

or pipe it through ruby with something like

Copyuser_ids = ActiveRecord::Base.connection.select_values(Message.select(:user_id).to_sql) # Rails 2
user_ids = Message.all.pluck(:user_id) # Rails 3+
User.where(:id => user_ids).update_all(:has_message => 1)

Be aware that MySQL can take many but not too many arguments. Passing a list of 100'000 arguments to an IN statement won't work.