Posted over 6 years ago. Visible to the public. Repeats.

Merge request check list

Merge requests are regularly rejected for the same few reasons.

We don't want that any more. Please attach the following list (colloquially known as "the TPS report") to future merge requests and check all (relevant) boxes:

Copy
I confirm that the code in this merge request... ------------------------------------------------ [ ] has green tests [ ] has been manually tested in the browser [ ] has no missing translations in the UI [ ] has no ugly UI changes (long content breaking out of boxes, elements without margins, etc.) [ ] works with lots of records without triggering a million queries or loading the world into memory [ ] sorts **all** lists (indexes, select dropdowns, ...) by either sorting in MySQL or using natural_sort in Ruby [ ] paginates long index lists [ ] has all necessary database indexes to speed up foreign key look ups and commonly used queries [ ] if it adds any migrations, takes care of existing records [ ] if it creates any new tables, adds created_at and updated_at timestamps [ ] if it makes major changes, check if the README needs to be changed

With GitLab Flavored Markdown:

Copy
I confirm that the code in this merge request fulfills the following requirements: --- | Status | Requirement | |----------|---------------------------------------------------------------------------------------------------------------| | [ ] | Has green tests | | [ ] | Has been manually tested in the browser | | [ ] | Has no missing translations in the UI | | [ ] | Has no ugly UI changes (long content breaking out of boxes, elements without margins, etc.) | | [ ] | Works with lots of records without triggering a million queries or loading the world into memory | | [ ] | Sorts **all** lists (indexes, select dropdowns, ...) by either sorting in MySQL or using natural_sort in Ruby | | [ ] | Paginates long index lists | | [ ] | Has all necessary database indexes to speed up foreign key look ups and commonly used queries | | [ ] | If it adds any migrations, takes care of existing records | | [ ] | If it creates any new tables, adds created_at and updated_at timestamps |

makandra has been working exclusively with Ruby on Rails since 2007. Our laser focus on a single technology has made us a leader in this space.

Owner of this card:

Avatar
Tobias Kraze
Last edit:
almost 2 years ago
by Henning Koch
Keywords:
checklist
About this deck:
We are makandra and do test-driven, agile Ruby on Rails software development.
License for source code
Posted by Tobias Kraze to makandra dev
This website uses cookies to improve usability and analyze traffic.
Accept or learn more