Read more

How to Make Your Code Reviewer Fall in Love with You

Judith Roth
December 08, 2020Software engineer at makandra GmbH

Why improve your code reviews?
Improving code review technique helps your reviewer, your team, and, most importantly: you.
Learn faster: If you prepare your changelist properly, it directs your reviewer’s attention to areas that support your growth rather than boring style violations. When you demonstrate an appreciation for constructive criticism, your reviewer provides better feedback .
Make others better: Your code review techniques set an example for your colleagues. Effective author practices rub off on your teammates, which makes your job easier when they send code to you.
Minimize team conflicts: Code reviews are a common source of friction. Approaching them deliberately and conscientiously minimizes arguments.

Techniques

  1. Review your own code first
  2. Write a clear changelist description
  3. Automate the easy stuff
  4. Answer questions with the code itself
  5. Narrowly scope changes
  6. Separate functional and non-functional changes
  7. Break up large changelists
  8. Respond graciously to critiques
  9. Be patient when your reviewer is wrong
  10. Communicate your responses explicitly
  11. Artfully solicit missing information
  12. Award all ties to your reviewer
  13. Minimize lag between rounds of review
Illustration web development

Do you need DevOps-experts?

Your development team has a full backlog? No time for infrastructure architecture? Our DevOps team is ready to support you!

  • We build reliable cloud solutions with Infrastructure as code
  • We are experts in security, Linux and databases
  • We support your dev team to perform
Read more Show archive.org snapshot
Posted by Judith Roth to makandra dev (2020-12-08 09:53)